-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to export logback code attributes #2518
Conversation
The metrics are those used on the .net side. |
...ngAgent/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/TraceLogBackTest.java
Outdated
Show resolved
Hide resolved
Doc could be new section right above https://docs.microsoft.com/en-us/azure/azure-monitor/app/java-standalone-config#logginglevel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go ahead and rebase on top of #2509 so you can run tests
@@ -216,6 +216,7 @@ public static class JdbcMasking { | |||
|
|||
public static class LoggingInstrumentation { | |||
public String level = "INFO"; | |||
public boolean captureCodeAttributes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be good to put it under logback-specific preview configuration, until we support across all logging instrumentations, e.g.
{
"preview": {
"captureLogbackCodeAttributes": true
}
}
d5ce9a5
to
9a5c323
Compare
Done |
I changed the base branch for this PR to the 1.18.0 PR temporarily to make it easier to review |
6b4389b
to
8038293
Compare
…nstrumentation release
This PR is part of the implementation of #2477.
The OTel code attributes will be available for Logback in the next
otel-java-instrumentation
release.This PR aims at exporting the related metrics.